[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 21 04:39:29 PDT 2019

Szelethus accepted this revision.
Szelethus added a comment.

LGTM, thanks! Please mark inlines as done as you fix them. If you like the file description I proposed, I'm happy to commit this on your behalf (or you might as well apply for a commit access, since you have a track record of high quality patches already).

Comment at: lib/StaticAnalyzer/Checkers/Yaml.h:9
+// This file contains a simple interface allow to open and parse yaml files.
Szelethus wrote:
> Is this actually the reason why we have this file? We already have a YAML parser in LLVM, what's does this file do that the "default" parser doesn't?
I would appreciate some comments, it still isn't immediately obvious why we need yet another yaml file. How about

"This file defines convenience functions for handling YAML configuration files for checkers/packages".



More information about the cfe-commits mailing list