[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 19 05:58:12 PDT 2019
ilya-biryukov added a comment.
`StaticAnalyzer/Core` does not depend on `clangFrontend` now, you can see this by looking at `lib/StaticAnalyzer/Core/CMakeLists.txt`:
Not a `StaticAnalyzer` expert, so I don't know whether it's acceptable to add this dependency to `clangStaticAnalyzerCore`, you'll have to find someone who owns the code to know whether this dependency is justified.
(My wild guess from looking at the names of the libraries would be that this dependency is not ok and the code should go into `clangStaticAnalyzerFrontend` instead. But again, not an expert here, just a guess).
But please add a dependency into `LINK_LIBS` inside `CMakeLists.txt` if you start depending on `clangFrontend`.
Most of these violations are found if you build in a `cmake -DBUILD_SHARED_LIBS=On` configuration.
CHANGES SINCE LAST ACTION
More information about the cfe-commits