[PATCH] D64922: [clangd] Added option to enable semantic highlighting via an experimental capability

Johan Vikström via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 07:10:34 PDT 2019


jvikstrom created this revision.
jvikstrom added reviewers: hokein, sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.

Adds option to enable semantic highlighting as an experimental capability. The reason for this is that it is not possible to add textDocument capabilities in the vscode extension as it is a strongly typed argument. The experimental capability is a normal JS like object and we can therefore send the capability there. However we can't remove the textDocument capability as theia relies on the capability to be in textDocument. (The same reasoning is why the server sends the TM scopes in the experimental capability if it got the capability as experimental).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64922

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/test/experimental-semantic-highlighting.test
  clang-tools-extra/clangd/test/semantic-highlighting.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64922.210557.patch
Type: text/x-patch
Size: 5733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190718/519835a4/attachment.bin>


More information about the cfe-commits mailing list