[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 06:38:05 PDT 2019


martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/clang/AST/ASTImporter.h:288
+                ASTContext &FromContext, FileManager &FromFileManager,
+                ASTUnit *FromUnit, bool MinimalImport,
+                std::shared_ptr<ASTImporterSharedState> SharedState);
----------------
balazske wrote:
> martong wrote:
> > Why do we still need `FromUnit` in this ctor? I thought the other ctor would handle that case.
> This is a private and common constructor that can handle both cases (called by the others).
Ok, I've missed that.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64554/new/

https://reviews.llvm.org/D64554





More information about the cfe-commits mailing list