[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

Shaurya Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 04:23:00 PDT 2019


SureYeaah created this revision.
SureYeaah added reviewers: kadircet, sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

- For now, we don't trigger in any case if it's an empty selection
- Fixed unittests


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64912

Files:
  clang-tools-extra/clangd/refactor/Tweak.cpp
  clang-tools-extra/clangd/refactor/Tweak.h
  clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp
  clang-tools-extra/clangd/unittests/TweakTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64912.210525.patch
Type: text/x-patch
Size: 5877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190718/21643b58/attachment.bin>


More information about the cfe-commits mailing list