[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates
Elizabeth Andrews via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 17 15:12:40 PDT 2019
eandrews added a comment.
I just realized I modified the summary when I uploaded a new patch, but did not add a comment about the changes I made. Based on feedback from the bug report (https://bugs.llvm.org/show_bug.cgi?id=40982), I changed my approach for this crash. This patch changes the type dependency of the member which causes the crash.
Currently, when member expressions are created, their type dependency is set based on the class it is part of and not its own type. I don't quite understand why, and changing it broke a whole lot of lit tests. So, in this patch I only attempted to modify the type-dependency of 'members of current instantiation' to set it based on it's type as opposed to the containing classes' type.
CHANGES SINCE LAST ACTION
More information about the cfe-commits