[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 17 08:13:39 PDT 2019

ilya-biryukov added a comment.

I tried to find a good place to emit unresolved typos earlier (to make sure CodeGen does not ever get `TypoExpr`), but couldn't find one.
Please let me know if there's some obvious place I'm missing.

Also open to suggestions for putting assertions on whether codegen is being called on `TypoExpr`s.
>From looking at the code, it seems that currently if the codegen eventually arrives at a `TypoExpr`, it will emit an error saying this expression is not yet supported.
There might be other failure modes (computing values of exprs containing `TypoExpr`, etc), but it feels like the current state should catch most of the potential bugs there.

This change seems to be an improvement over what we had before (clangd and libclang do not crash, no errors are lost) and it's very simple. So unless people object I would propose to land it even if it does not solve all of the problems around delayed exprs.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list