[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 17:09:51 PDT 2019


efriedma added inline comments.


================
Comment at: clang/lib/Parse/ParseStmt.cpp:104
+
+  if (isNullStmtWithAttributes()) {
+    MaybeParseGNUAttributes(Attrs);
----------------
If we're going to generally support statement attributes, it should be possible to apply them to non-null statements.  (Even if there aren't any valid attributes right now, that's likely to change in the future.)  Or is that not possible to implement for some reason?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64838/new/

https://reviews.llvm.org/D64838





More information about the cfe-commits mailing list