[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 13:11:54 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

> To avoid a similar inconsistence with host compilers that don't predefine _FILE_OFFSET_BITS=64
>  (e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted shortly.

I'm curious, what's the plan for that? I suppose the user can always take things into their own hands with -D and -U.

In any case, if you want to match newer GCCs, I'm for that. lgtm


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64482/new/

https://reviews.llvm.org/D64482





More information about the cfe-commits mailing list