[PATCH] D64062: Remove __VERSION__
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 15 10:39:33 PDT 2019
rnk added a comment.
In D64062#1584219 <https://reviews.llvm.org/D64062#1584219>, @saugustine wrote:
> This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert.
> The file is getcompiler.c:
I just want to point out that this code was already doing the wrong thing. It will report that the compiler is some incorrect version of GCC. After we add __VERSION__ back it will keep doing the wrong thing, which was sort of the point of removing it in the first place: to find such broken code and fix it. In any case, it sounds like it's not worth the effort, so let's just change the value of __VERSION__ instead of removing it.
CHANGES SINCE LAST ACTION
More information about the cfe-commits