[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 15 06:51:04 PDT 2019
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299
// return statement
> kadircet wrote:
> > left out this one ?
> Since that's an IntegerLiteral, this patch doesn't apply to it?
nvm this one, it was for "empyt selection triggering" case.
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:323
while(a < ^1)
// do while
I thought extractor didn't handle this case(missing braces).
What is the extraction in this case? Because if it is
auto dummy = a++;
while (a < 1)
it is not going to be semantically same.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits