[PATCH] D64653: clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target

James Nagurne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 22:49:19 PDT 2019


JamesNagurne added a comment.

In D64653#1584155 <https://reviews.llvm.org/D64653#1584155>, @MaskRay wrote:

> I committed this for you in rL365981 <https://reviews.llvm.org/rL365981> (it may have broken a Windows build for a long time. I wanted to fix it soon..). Thanks!
>
> > any platform that runs this test will fail with the error:
>
> Not-too-ancient Darwin, FreeBSD, Linux, NetBSD, OpenBSD, Solaris, etc support this, but notable exception is Windows:
>
>   % clang -target x86_64-windows -fsanitize=vptr -fno-rtti fsanitize.c '-###'
>   clang-9: error: unsupported option '-fsanitize=vptr' for target 'x86_64-unknown-windows-msvc'
>


Yes, my comment was rather misguided here. I didn't mean to say "All platforms", more like "All platforms that don't support -fsanitize=vptr". Specifically, this was affecting our embedded arm target.
Thanks for getting this in!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64653/new/

https://reviews.llvm.org/D64653





More information about the cfe-commits mailing list