[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

Ziang Wan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 17:20:37 PDT 2019


ziangwan added a comment.

In D64666#1583792 <https://reviews.llvm.org/D64666#1583792>, @xbolva00 wrote:

> In D64666#1583667 <https://reviews.llvm.org/D64666#1583667>, @ziangwan wrote:
>
> > In D64666#1583633 <https://reviews.llvm.org/D64666#1583633>, @xbolva00 wrote:
> >
> > > You can check also https://reviews.llvm.org/D52835. I hit there issue which I didn't know how to solve.
> >
> >
> > Hi David,
> >
> > Can you elaborate what issues you encountered? Thank you.
>
>
> I had duplicated warning for C++11+ - my new warning and C++11’s narrowing warning.
>
> Did you run ‘ninja check-clang’?


I ran `ninja check-clang` and got all passed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64666/new/

https://reviews.llvm.org/D64666





More information about the cfe-commits mailing list