r365956 - Revert driver: Don't warn about assembler flags being unused when not assembling

[Reid Kleckner via cfe-commits]

Author: rnk
Date: Fri Jul 12 13:44:57 2019
New Revision: 365956

URL: http://llvm.org/viewvc/llvm-project?rev=365956&view=rev
Log:
Revert driver: Don't warn about assembler flags being unused when not assembling

This reverts r365703 (git commit 101c1afdfd1c88f05da94c6fd317b489bb704f40)
and r365714.

This broke some autoconf-style assembler flags checks in the Linux
build:
https://github.com/ClangBuiltLinux/linux/issues/598

Modified:
    cfe/trunk/lib/Driver/ToolChains/Clang.cpp
    cfe/trunk/test/Driver/as-options.s

Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=365956&r1=365955&r2=365956&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Fri Jul 12 13:44:57 2019
@@ -3535,18 +3535,6 @@ void Clang::ConstructJob(Compilation &C,
   // Select the appropriate action.
   RewriteKind rewriteKind = RK_None;
 
-  // If CollectArgsForIntegratedAssembler() isn't called below, call it here
-  // with a dummy args list to mark assembler flags as used even when not
-  // running an assembler. Otherwise, clang would emit "argument unused"
-  // warnings for assembler flags when e.g. adding "-E" to flags while debugging
-  // something. That'd be somewhat inconvenient, and it's also inconsistent with
-  // most other flags -- we don't warn on -ffunction-sections not being used
-  // in -E mode either for example, even though it's not really used either.
-  if (!isa<AssembleJobAction>(JA)) {
-    ArgStringList DummyArgs;
-    CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D);
-  }
-
   if (isa<AnalyzeJobAction>(JA)) {
     assert(JA.getType() == types::TY_Plist && "Invalid output type.");
     CmdArgs.push_back("-analyze");

Modified: cfe/trunk/test/Driver/as-options.s
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/as-options.s?rev=365956&r1=365955&r2=365956&view=diff
==============================================================================
--- cfe/trunk/test/Driver/as-options.s (original)
+++ cfe/trunk/test/Driver/as-options.s Fri Jul 12 13:44:57 2019
@@ -35,26 +35,3 @@
 // RUN:   | FileCheck %s
 
 // CHECK: "-I" "foo_dir"
-
-// Test that assembler options don't cause warnings when there's no assembler
-// stage.
-
-// RUN: %clang -mincremental-linker-compatible -E \
-// RUN:   -o /dev/null -x c++ %s 2>&1 \
-// RUN:   | FileCheck --check-prefix=WARN --allow-empty %s
-// RUN: %clang -mincremental-linker-compatible -E \
-// RUN:   -o /dev/null -x assembler-with-cpp %s 2>&1 \
-// RUN:   | FileCheck --check-prefix=WARN --allow-empty %s
-// RUN: %clang -mimplicit-it=always -target armv7-linux-gnueabi -E \
-// RUN:   -o /dev/null -x c++ %s 2>&1 \
-// RUN:   | FileCheck --check-prefix=WARN --allow-empty %s
-// RUN: %clang -mimplicit-it=always -target armv7-linux-gnueabi -E \
-// RUN:   -o /dev/null -x assembler-with-cpp %s 2>&1 \
-// RUN:   | FileCheck --check-prefix=WARN --allow-empty %s
-// RUN: %clang -Wa,-mbig-obj -target i386-pc-windows -E \
-// RUN:   -o /dev/null -x c++ %s 2>&1 \
-// RUN:   | FileCheck --check-prefix=WARN --allow-empty %s
-// RUN: %clang -Wa,-mbig-obj -target i386-pc-windows -E \
-// RUN:   -o /dev/null -x assembler-with-cpp %s 2>&1 \
-// RUN:   | FileCheck --check-prefix=WARN --allow-empty %s
-// WARN-NOT: unused