[PATCH] D64062: Remove __VERSION__

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 11:50:45 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, minor changes



================
Comment at: docs/ReleaseNotes.rst:82
 
+Removed Compiler Options
+------------------------
----------------
I guess move the bullet to the generic "list of changes", since this isn't a flag or option.


================
Comment at: docs/ReleaseNotes.rst:85
+
+- Tthe ``__VERSION__`` macro has been removed.
+  Previously they both produced information designed for compatibility with GCC
----------------
typo "The"


================
Comment at: docs/ReleaseNotes.rst:86-87
+- Tthe ``__VERSION__`` macro has been removed.
+  Previously they both produced information designed for compatibility with GCC
+  4.2.1, but that should no longer be necessary. To get Clang's version, use the
+  :ref:`clang namespaced version macros <languageextensions-builtin-macros>`.
----------------
"Previously this macro was set to a string aiming to achieve compatibility with GCC 4.2.1, but that should no longer be necessary. To get Clang's version..."


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64062/new/

https://reviews.llvm.org/D64062





More information about the cfe-commits mailing list