[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

Wed Jul 10 23:44:45 PDT 2019

Hahnfeld added inline comments.

================
Comment at: clang/docs/OpenMPSupport.rst:165
++------------------------------+--------------------------------------------------------------+--------------+--------------------------------------------+
+| OMPD                         | OMPD interfaces                                              | mostly done  |                                            |
++------------------------------+--------------------------------------------------------------+--------------+--------------------------------------------+
----------------
jdoerfert wrote:
> Hahnfeld wrote:
> > This is not correct, at least it's not yet upstream.
> Is there anything upstreamed? What should I put for status and revisions/reviews?
I don't think there's a review yet. @protze.joachim ?

================
Comment at: clang/docs/OpenMPSupport.rst:198
++------------------------------+--------------------------------------------------------------+----------------------+--------------------------------------------+
+| device extension             | OMP_TARGET_FALLBACK env variable                             | :part:`worked on`    | D50522                                     |
++------------------------------+--------------------------------------------------------------+----------------------+--------------------------------------------+
----------------
kkwli0 wrote:
> Change OMP_TARGET_FALLBACK to OMP_TARGET_OFFLOAD which is in the spec.
This is done, see the linked revision.

================
Comment at: clang/docs/OpenMPSupport.rst:250
++------------------------------+--------------------------------------------------------------+----------------------+--------------------------------------------+
+| misc extension               | library shutdown (omp_pause_resource[_all])                  | :part:`worked on`    |                                            |
++------------------------------+--------------------------------------------------------------+----------------------+--------------------------------------------+
----------------
I think this should say partial, it's present in `libomp` after D55078.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64375/new/

https://reviews.llvm.org/D64375