[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 10 13:49:21 PDT 2019


ABataev marked an inline comment as done.
ABataev added a comment.

In D64356#1579154 <https://reviews.llvm.org/D64356#1579154>, @NoQ wrote:

> Ugh, i forced a lot of boilerplate on you. Hope it was worth it >.<
>
> Thank you!~


No problems, thanks for the review!



================
Comment at: test/Analysis/cfg-openmp.cpp:3
+
+// CHECK:        void xxx(int argc)
+// CHECK:        [B1]
----------------
NoQ wrote:
> Those are quite readable because of very verbose pretty-prints but generally i prefer to interleave code and `CHECK:` lines so that to easily see both on one screen and know what corresponds to what.
Ok, I will do this.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64356/new/

https://reviews.llvm.org/D64356





More information about the cfe-commits mailing list