[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

Wed Jul 10 07:49:59 PDT 2019

SjoerdMeijer added inline comments.

================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:237
+    break;
+  case llvm::AArch64::ArchKind::ARMV8_4A:
+    getTargetDefinesARMV84A(Opts, Builder);
----------------
SjoerdMeijer wrote:
> It is a good change, but I think you should either add tests for these cases, or remove this (temporarily) because it is not adding much at the moment.
Ah, sorry: "-march=armv8.4-a also enables this"
probably good to add some tests for v8.4 and v8.5 too then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64495/new/

https://reviews.llvm.org/D64495