[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 8 13:33:47 PDT 2019


rnk accepted this revision.
rnk added a subscriber: zturner.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I think @zturner wanted to teach lit to completely remove the Output/ directory for every test so we don't have to deal with stale files from previous tests hanging around. I remember objecting that we can't do that on startup since it's slow and not parallelized. However, I think we could probably add it as an early step to TestRunner.executeShTest so we don't have to add these extra 'rm' commands anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64301/new/

https://reviews.llvm.org/D64301





More information about the cfe-commits mailing list