[PATCH] D61681: [clangd] A code tweak to expand a macro

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 8 08:20:18 PDT 2019


ilya-biryukov updated this revision to Diff 208425.
ilya-biryukov marked 5 inline comments as done.
ilya-biryukov added a comment.

- Replace bsearch with partition_point.
- Include macro name in the title.
- Added a FIXME for empty selection case.
- Return null when no token is found.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61681/new/

https://reviews.llvm.org/D61681

Files:
  clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt
  clang-tools-extra/clangd/refactor/tweaks/ExpandMacro.cpp
  clang-tools-extra/clangd/unittests/TweakTests.cpp
  clang/include/clang/Tooling/Syntax/Tokens.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61681.208425.patch
Type: text/x-patch
Size: 8019 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190708/b637ce46/attachment.bin>


More information about the cfe-commits mailing list