[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 3 04:59:43 PDT 2019


hokein added a comment.

In D64127#1568093 <https://reviews.llvm.org/D64127#1568093>, @kadircet wrote:

> Could you also revert changes in `LSPDiagnosticCompare` in `Protocol.h`, that were introduced by rL363889 <https://reviews.llvm.org/rL363889>? (or bring back `fixits-duplication.test`)


Done, it looks like we don't need this change as we don't store all diagnostics of clang-tidy alias checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64127/new/

https://reviews.llvm.org/D64127





More information about the cfe-commits mailing list