[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 3 02:57:14 PDT 2019


hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

Clang-tidy checks may emit duplicated messages (clang-tidy tool
deduplicate them in its custom diagnostic consumer), and we may show
multiple duplicated diagnostics in the UI, which is really bad.

This patch makes clangd do the deduplication as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64127

Files:
  clang-tools-extra/clangd/Diagnostics.cpp
  clang-tools-extra/clangd/test/fixits-duplication.test
  clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64127.207740.patch
Type: text/x-patch
Size: 12492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190703/4ae9a17e/attachment.bin>


More information about the cfe-commits mailing list