[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 18:27:10 PDT 2019


NoQ marked an inline comment as done.
NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3009-3010
       for (const BugReport &Report : EQ) {
-        if (Report.getErrorNode()->getState() == N->getState())
+        if (Report.getErrorNode()->getState() == N->getState() &&
+            Report.getErrorNode()->getLocation() == N->getLocation())
           return true;
----------------
The fix in `test/Analysis/dump_egraph.c` is related to this change. Previously multiple nodes in the dump were marked as `"has_report": true` and the `CHECK` directives were in a wrong order but went unnoticed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64110/new/

https://reviews.llvm.org/D64110





More information about the cfe-commits mailing list