[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 15:48:16 PDT 2019


a_sidorin added a comment.

Hello Gabor,
This looks mostly good but I have a question inline.



================
Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1182
 
+      if (D1CXX->isLambda()) {
+        if (!D2CXX->isLambda())
----------------
Should we return false if `D1CXX->isLambda() != D2CXX->isLambda()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64075/new/

https://reviews.llvm.org/D64075





More information about the cfe-commits mailing list