[PATCH] D61909: Add Clang shared library with C++ exports

Kim Gräsman via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 01:56:19 PDT 2019


The Clang module libraries are all called libClang[A-Z][a-zA-Z]+.{a,so}, so
libclangcpp doesn't conflict with that, but I wonder if a dash would set it
apart even more clearly: libclang-cpp.

Or something like clang-all to show that it houses all clang modules?

Bikesheds are the best sheds.

- Kim

On Tue, Jul 2, 2019, 10:44 Sylvestre Ledru <sylvestre at debian.org> wrote:

> libclangcpp ?
>
> I think it is a pretty common pattern.
>
> On debian, apt-cache search 'lib.*cpp'  returns a bunch of libraries
> (libhdf5-cpp, libroscpp2d, libjsonrpccpp-dev, libmysqlcppconn7v5,
> libsvncpp3, libtercpp0v5, libyaml-cpp-dev, etc)
>
> S
>
>
> Le 02/07/2019 à 01:22, Chris Bieneman a écrit :
>
> The question is, what *should* it be called.
>
> While yes, the 's' in 'so' is shared, the "dylib" and "dll" extensions on
> Darwin and Windows have the same meaning too. The problem is libclang.so is
> already taken.
>
> I'm not attached to the name in any way, so I'm open to suggestions.
>
> We do have documentation on best practices for how to build distributions,
> which includes explanations of how to pick and choose what you want to
> install (http://llvm.org/docs/BuildingADistribution.html), so you
> shouldn't need an option to disable it.
>
> -Chris
>
> On Jul 1, 2019, at 6:13 PM, Tom Stellard via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> tstellar added a comment.
>
> In D61909#1563678 <https://reviews.llvm.org/D61909#1563678>,
> @sylvestre.ledru wrote:
>
> For now, it isn't part of the debian packaging.
>
> https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563
> it is removed as packaging phase as I have been told it isn't ready.
>
> Anyway, the lib should not keep this name.
> By definition, on linux, .so means shared. It should have a more explicit
> name.
>
> @beanz Can you please rename it? thanks
>
>
>
> I've filed a bug for this and marked it as a blocker for 9.0.0, because
> once we ship a release with this name, it will be harder to change:
> https://bugs.llvm.org/show_bug.cgi?id=42475
>
>
> Repository:
>  rC Clang
>
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D61909/new/
>
> https://reviews.llvm.org/D61909
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190702/8eb5ffeb/attachment.html>


More information about the cfe-commits mailing list