r364901 - clang-cl: Make /d1reportAllClassLayout actually work and improve test

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 03:22:11 PDT 2019


Author: nico
Date: Tue Jul  2 03:22:11 2019
New Revision: 364901

URL: http://llvm.org/viewvc/llvm-project?rev=364901&view=rev
Log:
clang-cl: Make /d1reportAllClassLayout actually work and improve test

See review thread for r301567.

Modified:
    cfe/trunk/include/clang/Driver/CLCompatOptions.td
    cfe/trunk/test/Driver/cl-options.c

Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CLCompatOptions.td?rev=364901&r1=364900&r2=364901&view=diff
==============================================================================
--- cfe/trunk/include/clang/Driver/CLCompatOptions.td (original)
+++ cfe/trunk/include/clang/Driver/CLCompatOptions.td Tue Jul  2 03:22:11 2019
@@ -63,7 +63,8 @@ def _SLASH_c : CLFlag<"c">, HelpText<"Co
 def _SLASH_d1PP : CLFlag<"d1PP">,
   HelpText<"Retain macro definitions in /E mode">, Alias<dD>;
 def _SLASH_d1reportAllClassLayout : CLFlag<"d1reportAllClassLayout">,
-  HelpText<"Dump record layout information">, Alias<fdump_record_layouts>;
+  HelpText<"Dump record layout information">,
+Alias<Xclang>, AliasArgs<["-fdump-record-layouts"]>;
 def _SLASH_diagnostics_caret : CLFlag<"diagnostics:caret">,
   HelpText<"Enable caret and column diagnostics (on by default)">;
 def _SLASH_diagnostics_column : CLFlag<"diagnostics:column">,

Modified: cfe/trunk/test/Driver/cl-options.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=364901&r1=364900&r2=364901&view=diff
==============================================================================
--- cfe/trunk/test/Driver/cl-options.c (original)
+++ cfe/trunk/test/Driver/cl-options.c Tue Jul  2 03:22:11 2019
@@ -14,7 +14,10 @@
 // C_P: "-E"
 // C_P: "-C"
 
-// RUN: %clang_cl /d1reportAllClassLayout -### -- %s 2>&1 | FileCheck -check-prefix=d1reportAllClassLayout %s
+// RUN: %clang_cl /d1reportAllClassLayout -### /c /WX -- %s 2>&1 | \
+// RUN:     FileCheck -check-prefix=d1reportAllClassLayout %s
+// d1reportAllClassLayout-NOT: warning:
+// d1reportAllClassLayout-NOT: error:
 // d1reportAllClassLayout: -fdump-record-layouts
 
 // RUN: %clang_cl /Dfoo=bar /D bar=baz /DMYDEF#value /DMYDEF2=foo#bar /DMYDEF3#a=b /DMYDEF4# \




More information about the cfe-commits mailing list