[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 18:00:14 PDT 2019


Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.

Are you alright with the namings? Those are randomly came out from my head and may you know some better one.

I like the idea about color tones, it is great we have a huge palette, just I still feels like it pretty well made for a dark theme.
Are you sure about the white background?

In D64051#1565801 <https://reviews.llvm.org/D64051#1565801>, @NoQ wrote:

> Ugly compound statement dumps that have been prevented:
>
> F9445982: Screen Shot 2019-07-01 at 5.52.51 PM.png <https://reviews.llvm.org/F9445982>


Yea, they are crazy. Thanks for that patch!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64051/new/

https://reviews.llvm.org/D64051





More information about the cfe-commits mailing list