[PATCH] D64015: [WIP][CUDA] Use shared MangleContext for CUDA and CXX CG

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 10:10:42 PDT 2019


erichkeane added a comment.

I don't know of any problems that the shared mangle context would cause, though I'm not sure about using the shared_ptr.  It seems to me that SOMEONE should own this, and the other should use a reference. IMO, the SharedMangleContexts should be a unique_ptr and CGCXXABI/CGCUDANV should have a reference to the proper implementation.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64015/new/

https://reviews.llvm.org/D64015





More information about the cfe-commits mailing list