[PATCH] D63773: [clangd] dummy variable extraction on a function scope

Shaurya Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 05:12:14 PDT 2019


SureYeaah marked 13 inline comments as done.
SureYeaah added inline comments.


================
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:71
+}
+std::vector<clang::Decl *> Extract::getReferencedDecls() {
+  // RAV subclass to find all DeclRefs in a given Stmt
----------------
kadircet wrote:
> this method doesn't use class state, maybe move it out-of-class to a function?
It uses the expr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63773/new/

https://reviews.llvm.org/D63773





More information about the cfe-commits mailing list