[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 06:55:14 PDT 2019


lebedev.ri requested changes to this revision.
lebedev.ri added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:41
+      llvm::StringRef(kAbseilThreadAnnotationsHeader);
+  if (actual_header.endswith(original_header)) {
+    FixItHint hint = FixItHint::CreateInsertion(Range.getBegin(), "ABSL_");
----------------
This isn't being tested. What happens if the macro comes from non-abseil header?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63929/new/

https://reviews.llvm.org/D63929





More information about the cfe-commits mailing list