[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.h:60
+  // Called by ClangdServer when some \p Highlightings for \p File are ready.
+  virtual void onHighlightingsReady(PathRef File,
+                                 std::vector<HighlightingToken> Highlightings) = 0;
----------------
we may add this interface to the existing `DiagnosticsConsumer`.


================
Comment at: clang-tools-extra/clangd/TUScheduler.h:157
+  void update(PathRef File, ParseInputs Inputs, WantDiagnostics WD,
+              bool WantHighlightings);
 
----------------
ilya-biryukov wrote:
> Can we avoid updating `TUScheduler`, `ParsingCallbacks` and compute the highlights inside `onMainAST`?
+1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63821/new/

https://reviews.llvm.org/D63821