[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 08:51:44 PDT 2019


sbc100 added a comment.

I wonder if we should use the linux/unix convention or `edata` `etext` and `end`?   Terrible names obviously but there is precedent.  I can't remember why I didn't do that for __data_end and __heap_base.

If not, then perhaps this should be called __data_start to match the existing __data_end?   Of course this means that command line flag is somewhat misnamed then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63742/new/

https://reviews.llvm.org/D63742





More information about the cfe-commits mailing list