[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 07:21:54 PDT 2019


martong marked 7 inline comments as done.
martong added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:7867
       if (PosF != ImportedFromDecls.end()) {
-        if (LookupTable)
+        if (SharedState->getLookupTable())
           if (auto *ToND = dyn_cast<NamedDecl>(ToD))
----------------
a_sidorin wrote:
> I think we can encapsulate these conditions into `SharedState::[add/remove]Decl[To/From]Lookup methods.
Good catch, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62376/new/

https://reviews.llvm.org/D62376





More information about the cfe-commits mailing list