r364147 - Revert "builtins: relax __iso_volatile_{load,store}32"

[Saleem Abdulrasool via cfe-commits]

Author: compnerd
Date: Sat Jun 22 19:53:03 2019
New Revision: 364147

URL: http://llvm.org/viewvc/llvm-project?rev=364147&view=rev
Log:
Revert "builtins: relax __iso_volatile_{load,store}32"

This reverts commit SVN r364137.  This seems to be cause problems with
casting in C.

Removed:
    cfe/trunk/test/CodeGenCXX/ms-intrinsics.cpp
Modified:
    cfe/trunk/include/clang/Basic/Builtins.def

Modified: cfe/trunk/include/clang/Basic/Builtins.def
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Builtins.def?rev=364147&r1=364146&r2=364147&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/Builtins.def (original)
+++ cfe/trunk/include/clang/Basic/Builtins.def Sat Jun 22 19:53:03 2019
@@ -827,11 +827,11 @@ LANGBUILTIN(_interlockedbittestandset_nf
 LANGBUILTIN(_interlockedbittestandset_rel,   "UcNiD*Ni", "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__iso_volatile_load8,   "ccCD*",     "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__iso_volatile_load16,  "ssCD*",     "n", ALL_MS_LANGUAGES)
-LANGBUILTIN(__iso_volatile_load32,  "LiLiCD*",   "n", ALL_MS_LANGUAGES)
+LANGBUILTIN(__iso_volatile_load32,  "iiCD*",     "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__iso_volatile_load64,  "LLiLLiCD*", "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__iso_volatile_store8,  "vcD*c",     "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__iso_volatile_store16, "vsD*s",     "n", ALL_MS_LANGUAGES)
-LANGBUILTIN(__iso_volatile_store32, "vLiD*Li",   "n", ALL_MS_LANGUAGES)
+LANGBUILTIN(__iso_volatile_store32, "viD*i",     "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__iso_volatile_store64, "vLLiD*LLi", "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__noop,           "i.",  "n", ALL_MS_LANGUAGES)
 LANGBUILTIN(__lzcnt16, "UsUs",    "nc", ALL_MS_LANGUAGES)

Removed: cfe/trunk/test/CodeGenCXX/ms-intrinsics.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/ms-intrinsics.cpp?rev=364146&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/ms-intrinsics.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/ms-intrinsics.cpp (removed)
@@ -1,17 +0,0 @@
-// RUN: %clang_cc1 -fms-compatibility -fsyntax-only %s -verify
-// expected-no-diagnostics
-
-struct S {
-  mutable long _Spinlock = 0;
-  void _Unlock() {
-    __iso_volatile_store32(&_Spinlock, 0);
-  }
-  int _Reset() {
-    long v = __iso_volatile_load32(&_Spinlock);
-    __iso_volatile_store32(&_Spinlock, 0);
-    return v;
-  }
-};
-
-S s;
-