r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 21 15:48:21 PDT 2019


I see Reid has reverted your original fix so instead of directly submitting, I have put the patch up for review first at https://reviews.llvm.org/D63678.

Douglas Yung

-----Original Message-----
From: Rainer Orth <ro at CeBiTec.Uni-Bielefeld.DE> 
Sent: Friday, June 21, 2019 14:46
To: Yung, Douglas <douglas.yung at sony.com>
Cc: cfe-commits at lists.llvm.org
Subject: Re: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Hi Douglas,

> I figured it out. Because you are using printf, you no longer need the 
> '\\c'. If I use the following RUN line, the test passes on both 
> Windows/linux (I don't have solaris to test unfortunately):
>
> // RUN: printf '%%s\n' '/I%S\Inputs\cl-response-file\ /DFOO=2' > 
> %t.rsp

I've now tested it myself successfully on amd64-pc-solaris2.11.  I'd figured the \\c -> \c part out already, but had to leave before understanding the %s problem.

> I can submit this patch for you if you would like.

That would be great, thanks a lot.

	Rainer


More information about the cfe-commits mailing list