[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

Fri Jun 21 15:48:24 PDT 2019

dyung added a comment.

In D63600#1554029 <https://reviews.llvm.org/D63600#1554029>, @rnk wrote:

> This causes the test to fail on Windows:
>  http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/7712
>
> There seems to be something wrong with the blamelist, so it didn't send email. I see this in the log from the previous build on that bot:
>
>   Updating llvm to 363241 at ...
>   
>
> But buildbot thinks the previous build was testing r364000, so it didn't send any notifications.
>
> `printf` seems like the wrong command to use to test backslash handling, since it interprets them as escapes. `%S` expands to a path containing backslashes, and the test logs seem consistent with that theory. I'll go ahead and revert this.

i have been working on a fix for this test with Rainer and we think we have one that works for both Windows and Solaris, but it still uses printf, although I'm not sure I understand your concern with using printf, so I don't know if it solves the problem you mention or not. But I have posted it as D63678 <https://reviews.llvm.org/D63678>.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63600/new/

https://reviews.llvm.org/D63600