[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 19 18:26:56 PDT 2019


chandlerc added a comment.

just a minor comment on one of these...



================
Comment at: clang/test/CodeGen/pgo-sample.c:10
+
+// The new pass manager analog to PrunEH is a combination of 'function-attrs'
+// and 'function(simplify-cgf)'.
----------------
s/PrunEH/PruneEH/


================
Comment at: clang/test/CodeGen/pgo-sample.c:12-14
+// NEWPM-DAG: PostOrderFunctionAttrsPass
+// NEWPM-DAG: SimplifyCFGPass
+// NEWPM-DAG: SampleProfileLoaderPass
----------------
The DAG worries me a bit ... The point here is to check that we remove EH before attaching sample profile data, and with the DAG it isn't clear that this happens *before*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63156/new/

https://reviews.llvm.org/D63156





More information about the cfe-commits mailing list