[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

Tue Jun 18 15:15:22 PDT 2019

lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.

================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252
+      // Finish "Frontend" section starting inside clang::ParseAST()
+      if (llvm::timeTraceProfilerEnabled())
+        llvm::timeTraceProfilerEnd();
----------------
anton-afanasyev wrote:
> lebedev.ri wrote:
> > I think i'm missing a point here.
> > Why do we want to end `"Frontend"` section here,  exclude all this following diag/optremark/etc stuff?
> The answer is below, we have `EmitBackendOutput()` there, calling Backend actions.
So, because we don't want "backend" timer to be within "frontend" timer.
Can you please add that as a comment here? :)

================
Comment at: clang/test/Driver/check-time-trace-sections.py:1
+#!/usr/bin/env python
+
----------------
anton-afanasyev wrote:
> lebedev.ri wrote:
> > Does some other test already require python?
> Sorry, what do you mean? I see many tests inside `clang/test/` and `llvm/test/` using python when Filecheck is not enough. Mostly they are using `python -c ...` as part of the pipe, but there are py-files as well.
I guess that was a dumb question, since lit is python-based.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63325/new/

https://reviews.llvm.org/D63325