[PATCH] D63425: [clangd] Perform merge for main file symbols.

Mon Jun 17 06:39:48 PDT 2019

hokein added a comment.

In D63425#1546010 <https://reviews.llvm.org/D63425#1546010>, @kadircet wrote:

> We also make use of `PickOne` in `updatePreamble` shouldn't that also cause similar troubles?

Yeah, we have similar problems in `updatePreamble`, but this is a correctness/performance tradeoff -- we have a large number of symbols in preamble, the cost of merging is too high.

However the number of main file symbols is relatively small (e.g. Sema.cpp only has 99 symbols), the cost is not too high.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63425/new/

https://reviews.llvm.org/D63425