[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Thomas Manceau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 15 07:55:07 PDT 2019


Blackhart added a comment.

In D63324#1543706 <https://reviews.llvm.org/D63324#1543706>, @lebedev.ri wrote:

> In D63324#1543626 <https://reviews.llvm.org/D63324#1543626>, @Blackhart wrote:
>
> > In D63324#1543609 <https://reviews.llvm.org/D63324#1543609>, @lebedev.ri wrote:
> >
> > > In D63324#1543607 <https://reviews.llvm.org/D63324#1543607>, @Blackhart wrote:
> > >
> > > > Modernize memcpy only if C++20 is enabled
> > >
> > >
> > > ... why?
> > >  This is also missing documentation,releasenotes changes.
> >
> >
> > According with the C++ reference, std::copy is only available since C++20.
>
>
> I don't see it there, can you quote?
>  https://godbolt.org/z/q2ryJi
>
> > There is another std::copy signature available since C++17, but it needs an extra parameter. I can implement it also.
> >  https://en.cppreference.com/w/cpp/algorithm/copy
> > 
> > I'm working on the unit tests and I'll make documentation/releasenotes after that.
> > 
> > Thanks for reviewing @lebedev.ri ;)


Sorry, I misread the reference. It's "until" C++20.
So from C++ birth to today ...

I'll revert my changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63324/new/

https://reviews.llvm.org/D63324





More information about the cfe-commits mailing list