[PATCH] D63335: [HIP] Change kernel stub name again

Fri Jun 14 11:30:53 PDT 2019

hliao added a comment.

In D63335#1543854 <https://reviews.llvm.org/D63335#1543854>, @tra wrote:

> In D63335#1543845 <https://reviews.llvm.org/D63335#1543845>, @hliao wrote:
>
> > it's requested from debugger people. they don't want to the host-side stub could match the device-side kernel function name. the previous scheme cannot prevent that.
>
>
> I understand that you want a different name for the stub. My question is why the ".stub" suffix was not sufficient and how does having a prefix instead helps? Making the name un-demangleable is undesirable, IMO. There should be a good reason to justify it.

it's based on debugger people told me, with ".stub", the debugger still could find it match the original device kernel even though it could find both of them. But, they want to match the original one only and leave the stub one intentionally unmatched.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63335/new/

https://reviews.llvm.org/D63335