[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 11 16:23:18 PDT 2019


leonardchan created this revision.
leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille.
leonardchan added a project: clang.
Herald added subscribers: dmgreen, Anastasia.

With the new pass manager enabled by default, some tests produce slightly different IR from the legacy PM. This patch just adds separate new PM runs and checks for the new PM IR.

This fixes:

  Clang :: CodeGen/avx512-reduceMinMaxIntrin.c
  Clang :: CodeGen/avx512f-builtins.c
  Clang :: CodeGen/avx512vl-builtins.c
  Clang :: CodeGen/avx512vlbw-builtins.c
  Clang :: CodeGenOpenCL/convergent.cl

For `CodeGenOpenCL/convergent.cl`, the new PM produced a slightly different for loop, but this still checks for no loop unrolling as intended.

For the avx-builtins tests, the new PM would produce extra bitcasts that did not affect the overall logic of the function, but I do not know a simple way to get rid of these bitcasts.

For `CodeGen/avx512-reduceMinMaxIntrin.c`, temporary local variables are produced in the codegen, but the allocas are out of order and the tests were pretty strict on order even though the logic/use of these variables was the same. Nearly all checks in this large file were broken, so I was hoping we could  run it with legacy only for now and come back to it later to make this easier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63174

Files:
  clang/test/CodeGen/avx512-reduceMinMaxIntrin.c
  clang/test/CodeGen/avx512f-builtins.c
  clang/test/CodeGen/avx512vl-builtins.c
  clang/test/CodeGen/avx512vlbw-builtins.c
  clang/test/CodeGenOpenCL/convergent.cl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63174.204186.patch
Type: text/x-patch
Size: 38429 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190611/7b17f9c4/attachment-0001.bin>


More information about the cfe-commits mailing list