[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

Tue Jun 11 04:16:24 PDT 2019

t.p.northover marked an inline comment as done.
t.p.northover added a comment.

Thanks for the suggestion Florian, and sorry it's taken so long to act on it. I've split the patch up as you suggest, I'll make this one cover the Triple bits.

================
Comment at: clang/lib/Basic/Targets/AArch64.h:93
+
+  bool hasInt128Type() const override;
 };
----------------
fhahn wrote:
> Why is this needed? It seems unused in the diff?
It's overriding a virtual function used to decide whether __int128 is allowed, and the default implementation checks the pointer width.

We're still AArch64 though so we can support __int128 just as well with 32-bit or 64-bit pointers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61939/new/

https://reviews.llvm.org/D61939