[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

Mon Jun 10 20:25:38 PDT 2019

ahatanak added a comment.

In D62988#1537082 <https://reviews.llvm.org/D62988#1537082>, @rjmccall wrote:

> Does this lead to C/C++ ABI mismatches?  Should we just honor this in C++ as well by ignoring it when deciding to delete special members?  Is taking such a general name a good idea if it's language-specific?  Richard, thoughts?

This is a C-only attribute, so clang will emit a diagnostic (warning 'attribute ignored') if the attribute is used to annotate a member of a C++ union. I think that would be sufficient to prevent possible C/C++ ABI mismatches?

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62988/new/

https://reviews.llvm.org/D62988