[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729
+/// \code
+/// void .omp_mapper.<type_name>.<mapper_id>.(void *rt_mapper_handle,
+///                                           void *base, void *begin,
----------------
lildmh wrote:
> ABataev wrote:
> > This function looks like the universal one, regardless of the type `<type_name>` specifics. Do we really need to generate it for each particular type and mapper? Or we could use the same function for all types/mappers?
> I think we need a particular mapper function for each type and mapper, because the code generated within the mapper function depends on what type and what mapper it is.
Hmm, maybe I'm wrong but I don't see significant mapper or type-specific dependencies in this mapper function. It uses the pointer to type and size of the type, but this information can be generalized, I think. Could you point the lines of code that are type and mapper specific?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59474/new/

https://reviews.llvm.org/D59474