[PATCH] D62808: [clangd] Print the ignored variant symbols

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 7 03:10:42 PDT 2019


hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/include-mapping/gen_std.py:119
+    ( a list of tuple (symbol_name, relative_path_to_symbol_page),
+      a list of tuple (variant_symbol_name, caption_text) )
   """
----------------
sammccall wrote:
> this is a significantly more complicated signature - do we need the extra precision in the log message vs e.g. `Ignored variant of symbol abs from path/to/complex.html`?
I think the current information is sufficient (`Ignore variant of symbol abs(complex)`), we are more caring about the entry name `symbol_name (caption)` (it is easy for us to find it in the symbol index page).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62808/new/

https://reviews.llvm.org/D62808





More information about the cfe-commits mailing list