[PATCH] D62971: [HIP] Remove the assertion on match between host/device names.

Thu Jun 6 12:58:43 PDT 2019

hliao marked 2 inline comments as done.
hliao added inline comments.

================
Comment at: clang/test/CodeGenCUDA/unnamed-types.cu:5
+
+// CHECK: @0 = private unnamed_addr constant [40 x i8] c"_Z2k0IZZ2f1PfENK3$_0clES0_EUlfE_EvS0_T_\00"
+
----------------
device-side mangled name, notice that `$_0` refers to the unnamed closure in f1.

================
Comment at: clang/test/CodeGenCUDA/unnamed-types.cu:24
+// CHECK: @__hip_register_globals
+// CHECK: __hipRegisterFunction{{.*}}_Z2k0IZZ2f1PfENK3$_1clES0_EUlfE_EvS0_T_{{.*}}@0
----------------
the registration of host-side stub function to the device-side function name, which is defined in `@0`. Notice that the host-side stub function has `$_1`, which refers to the closure in f1 as there's another closure (host-only) in f0.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62971/new/

https://reviews.llvm.org/D62971