[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added inline comments.


================
Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925
+    // FIXME: this should only be set on CK_CurrentParameter.
+    Signal.ContainsActiveParameter = true;
+  }
----------------
Hi!

gcc (7.4) warns on this code:

```
error: parameter 'Signal' set but not used [-Werror=unused-but-set-parameter]
                              SignatureQualitySignals Signal) const {
                                                      ^~~~~~
```
Should Signal be a reference? Or is it specifically not a reference right now due to the FIXME?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62476/new/

https://reviews.llvm.org/D62476