[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 17:56:03 PDT 2019


Szelethus added a comment.

I like the idea, but will need more time to get familiar with `CallEvent` to formally accept.

> When matching C standard library functions in the checker, it's easy to forget that they are often implemented as macros that are expanded to compiler builtins. Such builtins would have a different name, so matching the callee identifier would fail, or may sometimes have more arguments than expected (so matching the exact number of arguments would fail, but this is fine as long as we have all the arguments that we need in their respective places.

Just a name an issue that came up recently, in the case of D59812 <https://reviews.llvm.org/D59812>, we probably shouldn't need to strip `"__builtin_"` off.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62556/new/

https://reviews.llvm.org/D62556





More information about the cfe-commits mailing list