[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 3 01:06:05 PDT 2019


gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:5
+
+void f() {
+  int pipefd[2];
----------------
Please give the tests informative names instead of `f`, `g` etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61967/new/

https://reviews.llvm.org/D61967





More information about the cfe-commits mailing list